Skip to content

Frontend/Templates: Atomic PR for all recent commits#4410

Closed
mudit06mah wants to merge 12 commits intokubernetes-sigs:mainfrom
mudit06mah:bigPR
Closed

Frontend/Templates: Atomic PR for all recent commits#4410
mudit06mah wants to merge 12 commits intokubernetes-sigs:mainfrom
mudit06mah:bigPR

Conversation

@mudit06mah
Copy link
Contributor

Summary

This PR is an atomic PR for all recent commits made in:
#4379
#4380
#4381
#4399
#4402

Related Issue

Fixes:
#4363
#4364
#4356
#4348
#4314

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mudit06mah
Once this PR has been reviewed and has the lgtm label, please assign joaquimrocha for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 21, 2026
@mudit06mah
Copy link
Contributor Author

@skoeva Please confirm if PR: #4382 has to be merged as well :)

@illume
Copy link
Contributor

illume commented Jan 21, 2026

Thanks for this. But… sorry, can you please have one PR per issue?

@illume illume closed this Jan 21, 2026
@illume
Copy link
Contributor

illume commented Jan 21, 2026

I would suggest to try to get one PR merged first so you can learn how things are done in this project before continuing on with other ones.

@mudit06mah
Copy link
Contributor Author

Thanks for this. But… sorry, can you please have one PR per issue?

@skoeva asked me to create an atomic PR instead of individual ones:
#4402 (review)

My bad for not adding proper commit messages, should I redo these PRs with appropriate commit messages?

@skoeva
Copy link
Contributor

skoeva commented Jan 21, 2026

We do atomic commits - you can do an interactive rebase (git rebase -i) to squash your commits under each PR into one. The contribution guidelines should be helpful

@mudit06mah
Copy link
Contributor Author

@illume @skoeva it appears that I have misunderstood the word atomic, I thought it meant to create a big single PR (T_T)
I would like to apologize for this misunderstanding and redo my commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants